[Rpm-maint] [rpm-software-management/rpm] Error if a macro in a comment is expanded to multiple lines (#124)

Panu Matilainen notifications at github.com
Wed Jan 18 15:03:15 UTC 2017

Seems I missed the return with error code earlier, possibly due to testing by commenting %configure in %prep where this doesn't do anything at all. So it seems to do what it promises in eg spec preample, but spec scriptlets are special for the macro expansion warning already.

I'm not really happy with any of the existing or proposed macros-in-comments hacks. Most of the time expanding macros in comments is perfectly harmless and the warning rpm currently emits is just unnecessary noise, and yet does not warn in many cases where it would matter. And this outlaws commenting multiline macros. Which, if you really think about it, seems totally absurd.

If we end up agreeing that multiline macros are special enough that we need to do something differently wrt them then we might as well do what the user intended and not expand the bleeping line, instead of failing with an unhelpful error.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170118/4de11b64/attachment.html>

More information about the Rpm-maint mailing list