[Rpm-maint] [rpm-software-management/rpm] Correctly detect Transmeta Crusoe as i686 (#254)

Neal Gompa (ニール・ゴンパ) notifications at github.com
Thu Jul 13 09:30:11 UTC 2017


Conan-Kudo requested changes on this pull request.

Could you please split the unrelated change in this patch into another PR? I know it's trivial, but let's not have them bundled up for no reason.

> @@ -1103,6 +1111,12 @@ static void defaultMachine(rpmrcCtx ctx, const char ** arch, const char ** os)
 #		endif
 #	endif
 
+#if defined(__linux__)
+	/* in linux, lets rename parisc to hppa */
+	if (rstreq(un.machine, "parisc"))
+	    strcpy(un.machine, "hppa");

This feels like an unrelated change. As far as I know the Crusoe has nothing to do with `hppa`...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/254#pullrequestreview-49724520
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170713/7513abd7/attachment.html>


More information about the Rpm-maint mailing list