[Rpm-maint] [rpm-software-management/rpm] Also test architecture in "refresh" test when not colored. (#253)

[Neal Gompa (ニール・ゴンパ)]

Conan-Kudo commented on this pull request.



>      /* XXX shouldn't we also do this on colorless transactions? */
     if (rpmtsColor(ts)) {
-	rpmdbSetIteratorRE(mi, RPMTAG_ARCH, RPMMIRE_STRCMP, rpmteA(te));
 	rpmdbSetIteratorRE(mi, RPMTAG_OS, RPMMIRE_STRCMP, rpmteO(te));

Shouldn't all of this be tested regardless of color?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/253#pullrequestreview-49725112
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170713/995a8583/attachment-0001.html>