[Rpm-maint] [rpm-software-management/rpm] Also test architecture in "refresh" test when not colored. (#253)

Michael Schroeder notifications at github.com
Thu Jul 13 11:34:27 UTC 2017


mlschroe commented on this pull request.



> @@ -511,13 +511,14 @@ void rpmpsmNotify(rpmpsm psm, int what, rpm_loff_t amount)
  */
 static void markReplacedInstance(rpmts ts, rpmte te)
 {
+    /* this must match rpmNameVersionCompare in depends.c */

No, please don't, the comment is correct. We do have rpmNameVersionCompare in depends.c. See the nameversioncompare.diff patch...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/253#discussion_r127192923
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170713/03d46dce/attachment.html>


More information about the Rpm-maint mailing list