[Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

Mark Wielaard mark at klomp.org
Fri Jul 21 11:24:01 UTC 2017


Hi,

On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote:
> I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly
> undefines major, minor, and makedev prior to defining its own versions of
> these macros.
> 
> My guess is that these undefs are not needed.

You are right. This makes the patch simpler. Now we only need to fix the
AC_HEADER_MAJOR check. Cleaned up patch attached. Retested on rhel7 and
fedora26.

sys/mkdev.h is a solaris/bsd thing. I checked and they also undef the
macros before (re)defining them. Although there they might not be
defined in another header in the first place.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-config-Detect-major-minor-warnings-and-include-the-c.patch
Type: text/x-patch
Size: 1972 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170721/55c66f87/attachment.bin>


More information about the Rpm-maint mailing list