[Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)

Igor Gnatenko notifications at github.com
Fri Jun 2 08:18:55 UTC 2017

ignatenkobrain commented on this pull request.

> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
     return prefix;
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+    return rpmlogMsgPrefixColor[pri&0x7];
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+    static const char fubar[] =
+	"Error occurred during writing of a log message";
+    FILE *msgout = (stdlog ? stdlog : stderr);
+    const char * colorOn = isatty(fileno(msgout))

I would prefer to have some macro/option to force enabling/disabling colors (like a --color[=WHEN] where WHEN is "auto", "always", "never")...

because when you would be passing that to `less`, you could pass `-R` and it will show you colors in pager... Quite useful.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170602/1954708d/attachment.html>

More information about the Rpm-maint mailing list