[Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)

proyvind notifications at github.com
Fri Jun 2 17:06:31 UTC 2017

disable_fix_foo are poor grammar, and not only 'disable' found to be consitent with was %_disable_source_fetch..

why changing "wuzz out"  to "quit" in comment? in order to not offend some unlikely person, or just plain political correctness (not really mutually exclusive)?

For pkgconfig, I made it more than evidently clear it being useful (and never dropped from #122).

It's the root cause for majority of all double slashes in paths with the result of different hacks added to debugedit without the actual ability to really workaround the issues for all scenarious..

The idea of that trimming away extra slashes in pkgconfig files having a high risk of causing breakage (despite of it's triviality), not even if it's clear that it's desirable is irrational.

Fixing the pkgconfig files and the actual root cause of most double slash issues with debugedit is hard to dispute as being desired over hacks and breakages with debugedit caused by not fixing the actual cause, which this script does..

I don't see the rationale for creating a new PR rather than just commenting on the existing one, nor much for the changes either.

Changing single comments in scripts fully authored by for no technical/practical reasons is what to be considered as poor etiquette..

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170602/b27328a3/attachment-0001.html>

More information about the Rpm-maint mailing list