[Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

proyvind notifications at github.com
Fri Jun 9 15:40:29 UTC 2017


You even caught some design shortcomings of rpm. and improved on poor implementations, bravo!

While only having quickly reviewed code, (but having knowledge of openmp and code in question at leastt), only thing I can come to think of is more aestetics, ie.
+    #pragma omp critical(rpmstrpool)
+    {
     if (pool && sid > 0 && sid <= pool->offs_size) {
        slen = strlen(pool->offs[sid]);
     }
+    }

    #pragma omp critical(rpmstrpool) {
        if (pool && sid > 0 && sid <= pool->offs_size) {
        slen = strlen(pool->offs[sid]);
        }
    }

would be more readable IMO.

But wars can't possible have started by less, so I give my approval after giving a first sight. :+1:  :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/226#issuecomment-307423819
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170609/6c806782/attachment-0001.html>


More information about the Rpm-maint mailing list