[Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

Panu Matilainen pmatilai at redhat.com
Fri Mar 24 06:44:54 UTC 2017


On 03/23/2017 04:37 PM, Mark Wielaard wrote:
> On Wed, 2017-03-22 at 14:37 +0200, Panu Matilainen wrote:
>> Guess there's some unhandled corner left still :)
>
> Yeah, that was because my fix was bogus :{
>
> It didn't construct the linkpath correctly (because it was relative). It
> checked with readlink (), but that doesn't fully expand the links, it
> should have used canonicalize_file_name () on both the link and the
> target (because the target is itself a symlink). And even then it
> wouldn't have worked because we don't know which duplicate the compat
> link is targeting, so the first existing target would always win.
>
> So back to the drawing board. The problem is the compat links in case
> there are duplicate build-ids. We don't want the compat links to
> "duplicate" the duplication search already done for the buildids already
> done. So in this new patch instead of saying we want to create a compat
> link when calling addNewBuildIDSymlink, we ask to search (and return)
> the number of duplicates found. We can then use that to create the
> compat links directly (with the correct duplication counter).
>
> Attached is your original patch plus my don't do duplication search for
> compat links change. That makes the testsuite pass and the popt
> short-circuit example work for me.

Confirmed, applied, and many many thanks.

	- Panu -



More information about the Rpm-maint mailing list