[Rpm-maint] [PATCH 5/5] Include system.h in ima and syslog plugins

Panu Matilainen pmatilai at redhat.com
Fri Mar 24 11:04:27 UTC 2017


On 03/23/2017 08:23 PM, Gleb Fotengauer-Malinovskiy wrote:
> Currently, there is no harm if config.h is not included in these files
> because they are not sensitive to macros defined in config.h, but any
> code added later or any plugin created using these plugins as examples
> might be affected by these macros and therefore has to include config.h.
>
> An example of bug when this header is not included properly can be seen
> in the previous commit.
>
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm at altlinux.org>
> ---

Patches 1-2 and 4-5 applied, thanks!

As for the setprogname() thing, I'm still pondering whether to fix it 
instead of just dropping. Replacing an almost-there implementation with 
a "no suitable implementation found" error doesn't seem so nice :)

	- Panu -


More information about the Rpm-maint mailing list