[Rpm-maint] [PATCH 3/5] Drop local implementation of xsetprogname/xgetprogname

Panu Matilainen pmatilai at redhat.com
Fri Mar 24 11:59:27 UTC 2017


On 03/23/2017 08:22 PM, Gleb Fotengauer-Malinovskiy wrote:
> It can be dropped because this code was never actually enabled.
> Actually, this implementation *surely* never ever compiled.
>
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm at altlinux.org>

After spending a few minutes looking at what it'd take to properly link 
etc ... applied. I dont have a whole lot of sympathy for untested code, 
and rpm has survived 20+ years without a local implementation of this.

On a related note, I suspect the allegedly increased portability in the 
patch adding this local implementation actually broke rpm on some OS'es 
where it previously working because that __progname is not a glibc-only 
thing, and replacing it with a broken implementation...

	- Panu -


More information about the Rpm-maint mailing list