[Rpm-maint] [rpm-software-management/rpm] Reserving space in the signature header (#183)

Jeff Johnson notifications at github.com
Tue Mar 28 15:21:01 UTC 2017


My bad for not noticing.

Good that padding has been added by adding (apparently) 0x1000 to the data size:
`00000060: 8ead e801 0000 0000 0000 0006 0000 1074  ...............t`

Adding a "free space" tag (as @rpm5.org) provides an indication that the signature header is padded.

Meanwhile, the metadata header is not aligned on (say) a 0x1000 offset from beginning of file
`
00001120: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00001130: 0000 0000 0000 003e 0000 0007 ffff ffa0  .......>........
00001140: 0000 0010 0000 0000 8ead e801 0000 0000  ................
00001150: 0000 0039 0000 437e 0000 003f 0000 0007  ...9..C~...?....
00001160: 0000 436e 0000 0010 0000 0064 0000 0008  ..Cn.......d....
`

Conventionally using a known offset would make mmap and HTTP byte ranges easier to use, and
its a bit easier to remember 4096 (or 0x1000) than it is to remember 4424 (ox 0x1148).

But having some constant offset is better than rewriting rpm package files.

(aside)
Adding padding between the metadata header and the payload might also be attempted to align the payload on a page boundary might be useful too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/183#issuecomment-289805262
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170328/f8be1137/attachment.html>


More information about the Rpm-maint mailing list