[Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)

soig notifications at github.com
Thu Nov 2 15:45:09 UTC 2017


On 2 November 2017 at 15:24, Thierry Vignaud <thierry.vignaud at gmail.com>
wrote:

>
> On 2 November 2017 at 00:05, Igor Gnatenko <notifications at github.com>
> wrote:
>
>> This might look too magic, but what it does in short:
>>
>>    - Replace /usr/bin/env foo with /usr/bin/foo.. One could argue on
>>    this, so we could add some macro to disable this. In Fedora it is even
>>    prohibited by guidelines now. This brp would help a lot!
>>    - Drop shebang from non-executable files.. Having shebangs in
>>    non-executable files doesn't make sense to me. If you think I'm wrong, I'm
>>    ready to listen!
>>    - If shebang is empty or doesn't exist, but file is executable -
>>    remove executable bit, most likely it will not work anyway, only by luck
>>    - Error out on shebangs like #!perl, this works only by luck
>>
>> cc @jasontibbitts <https://github.com/jasontibbitts> @Conan-Kudo
>> <https://github.com/conan-kudo>
>>
>>>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341269384>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AC5qkUhawknpPGQ9dF-H4OD5gGnyQHXlks5syPlIgaJpZM4QO8ad>
>> .
>>
> ​In Mageia, this is done differently: the shebang is left as it, but the
> auto requires is translated from "/bin/env" to "/bin/foo"
> There's other patches in order to emit requires on packages instead of
> file deps:
> http://svnweb.mageia.org/packages/cauldron/rpm/current/
> SPECS/rpm.spec?revision=1173947&view=markup#l155
>
> ​The patch:
http://svnweb.mageia.org/packages/cauldron/rpm/current/SOURCES/script-env.diff?revision=870745&view=markup
​


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341464346
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20171102/8027a323/attachment.html>


More information about the Rpm-maint mailing list