[Rpm-maint] [rpm-software-management/rpm] Fix error message for rpmlock (#355), by removing dead code (#358)

Jeff Johnson notifications at github.com
Sat Nov 25 02:09:26 UTC 2017


I should point out that this is not "dead code" since the existence of a fcntl(2) read lock will prevent a write lock even if rpm itself does not expose the API to test read locks.

That being said: your change is entirely sane, the fcntl(2) locking in RPM is badly flawed, made worse by permission checking on 0755 root:root permissions on /var/lib/rpm files. Until the permission problems are reasonably dealt with, your patch is as good as anything else.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/358#issuecomment-346913026
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20171125/c318632c/attachment.html>


More information about the Rpm-maint mailing list