[Rpm-maint] [rpm-software-management/rpm] rpmidxGetInternal(): leak on realloc() failure (#357)

[Panu Matilainen]

Not sure where you're pulling that 130 malloc() references from, certainly there aren't that many of them. I see something ~34 actual malloc() calls in the code.

The typical use of malloc()/realloc() (as opposed to rpm's wrappers) comes from code originally developed outside rpm, including ndb. Using them isn't forbidden, it's just that in case non-rpm allocators are used, they need to check for and handle errors. Which code originating outside rpm usually does, including ndb.

Sure it could be converted to xmalloc()/xrealloc() and remove some then redundant error checking, 
@mlschroe any thoughts/preferences wrt that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/357#issuecomment-347140209
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20171127/5c4d1b53/attachment.html>