[Rpm-maint] [rpm-software-management/rpm] Fail to check signature (#270)

[Panu Matilainen]

Oh okay, took a dog-walk for it to register: in rpm5 RPMSIGTAG_PADDING is used for the actual padding between the signature and main header, which is different from rpm.org's RPMSIGTAG_RESERVEDSPACE. From the initial description of #183 I assumed it was essentially the same and, I admit, didn't bother with the other details you provided later. So it's different, in a number of ways, my bad for assuming otherwise.

But in that case, calling headerReload() again after adding the padding tag seems wrong, it's just that the second call doesn't actually seem to do much anything so it ends up being harmless. This is true of rpm.org's headerReload() as well BTW - it only works once to actually pull it all into that single contiguous region. I seem to recall running into that once or twice but never got around to look into it just then, there hasn't been much of a reason to bother. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/270#issuecomment-347795350
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20171129/537d2f72/attachment.html>