[Rpm-maint] [rpm-software-management/rpm] Revert "Sync disks at the end of transactions (RhBug:1461765)" (#318)

Colin Walters notifications at github.com
Fri Sep 8 10:32:42 UTC 2017


In active use?  I don't think there's that many.   Certainly the original bug report was from someone using dnf.

I just don't understand the logic for pushing this directly into librpm without even making it configurable after all of the feedback from people using librpm for higher level tools on the original commit.

The simplest would seem to be making `rpmtsSync()` public API.  Then higher level tools could call it as desired.  Having direct `rpm -i` calls invoke it and whether or not to do it by default seems like something that could be addressed later.

And to repeat, I definitely don't want this for rpm-ostree; we already have our own `syncfs()` calls and there we actually check the return codes for example; and make it so that if anything failed, the system is left unchanged.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/318#issuecomment-328069038
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170908/438d9de0/attachment.html>


More information about the Rpm-maint mailing list