[Rpm-maint] [rpm-software-management/rpm] work with lua 5.3 without compat mode (#169)

Panu Matilainen notifications at github.com
Mon Apr 9 12:32:51 UTC 2018


This doesn't even compile against a build of Lua where the compat-stuff is actually disabled, due to missing port of luaL_openlib() in rpmio/rpmlua.c. What's worse, when using a version of lua that it does compile against, it causes any attempt to use rpm macros crash:
```
$ ./rpm --eval "%{_lib}"
PANIC: unprotected error in call to Lua API (attempt to index a nil value)
Aborted (core dumped)
```

....which in terms of the test-suite means:
```
## ------------- ##
## Test results. ##
## ------------- ##

ERROR: All 415 tests were run,
406 failed (4 expected failures).
```

Folks, if you're submitting untested code then at least have the courtesy of stating so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/169#issuecomment-379735523
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180409/76adc31c/attachment.html>


More information about the Rpm-maint mailing list