[Rpm-maint] [rpm-software-management/rpm] fileattrs: Don't scan libraries in $libdir/haswell for Provides (#499)

[Patrick McCarty]

phmccarty commented on this pull request.



> @@ -0,0 +1,4 @@
+%__elf_requires		%{_rpmconfigdir}/elfdeps --requires %{?__filter_GLIBC_PRIVATE:--filter-private}

Do the macros need to use the `__elfoptimized` prefix instead of `__elf`? I've noticed that the macros from other .attr files are named after the file itself (without suffix).

> @@ -0,0 +1,4 @@
+%__elf_requires		%{_rpmconfigdir}/elfdeps --requires %{?__filter_GLIBC_PRIVATE:--filter-private}
+%__elf_magic		ELF (32|64)-bit.*$

This line appears to originate from the Clear Linux patched version of elf.attr, but it should probably use the same value as `%__elf_magic` from elf.attr instead.

> @@ -0,0 +1,4 @@
+%__elf_requires		%{_rpmconfigdir}/elfdeps --requires %{?__filter_GLIBC_PRIVATE:--filter-private}
+%__elf_magic		ELF (32|64)-bit.*$
+%__elf_flags		exeonly
+%__elf_exclude_path     ^(/usr)?/lib(64)?/(i686|x86_64|sse2|haswell|tls)/

Should be `%__elf_path` instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/499#pullrequestreview-144153183
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180807/f6f24bbc/attachment.html>