[Rpm-maint] [rpm-software-management/rpm] RFE: All macro expansion failures should include line numbers for original macro location. (#491)

[Jeff Johnson]

(aside)
It's rather amusing for this author to read "optimization" patches to macros/argv code when I know quite well the reasons the code was written the way it was. E.g. bsearch(3) was used as a store  largely because of many other uses of bsearch(3) in rpm (i.e. consistency), and because code reviews at RedHat -- such as they were -- strived to use library routines wherever available. The argv.h routines were thrown together on a Saturday afternoon out of frustration with no simple and useful routines for containers of ints/strings anywhere I could find

And the ulterior motive with both macros/argv was maintenance free, not performance. Both implementations achieved that goal quite well when used as expected, but perhaps not as packagers wished. Oh well ...

Ah yes, Alexey's code ... I've dealt with his code many times. It's rather sad that not much resulted from his 2013 patches 5 years later. Again, oh well ...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/491#issuecomment-413212831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180815/99528e91/attachment.html>