[Rpm-maint] [rpm-software-management/rpm] Optimize and unite setting CLOEXEC on fds (#444)

Kirill Kolyshkin notifications at github.com
Wed May 30 01:12:10 UTC 2018


@ffesti @pmatilai please see the updated (and rebased) patch set.

> rpm comment style is "/* foo */", "// foo" should not be used

I actually thought about it so I did `git grep '// '` which revealed quite a few uses and so I went ahead.
Anyway, done.

> and put the prototype to rpmio_internal.h

I'm assuming you are OK with `luaext/lposix.c` to have `#include "rpmio/rpmio_internal.h"` added.

> The patch set would be even nicer if moving the code into its own function would be separated from any changes to the code.

done

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/444#issuecomment-392998437
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180529/73f202a4/attachment.html>


More information about the Rpm-maint mailing list