[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

Panu Matilainen notifications at github.com
Tue Nov 6 12:13:36 UTC 2018


pmatilai commented on this pull request.



>  	case PART_CLEAN:
-	    parsePart = parseBuildInstallClean(spec, parsePart);
+	    parsePart = parseSimpleScript(spec, "%clean", &(spec->clean));

The parseBuildInstallClean() -> parseSimpleScript() generalisation makes sense regardless of the rest of this, please split that part into a separate commit and push. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-171988236
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20181106/0ce83879/attachment.html>


More information about the Rpm-maint mailing list