[Rpm-maint] [rpm-software-management/rpm] Info how beneficial is dwz compression. (#535)

[Igor Gnatenko]

ignatenkobrain commented on this pull request.



> @@ -489,6 +489,7 @@ if $run_dwz \
    && [ -d "${RPM_BUILD_ROOT}/usr/lib/debug" ]; then
   readarray dwz_files < <(cd "${RPM_BUILD_ROOT}/usr/lib/debug"; find -type f -name \*.debug | LC_ALL=C sort)
   if [ ${#dwz_files[@]} -gt 0 ]; then
+    size_before="`du -s ${RPM_BUILD_ROOT}/usr/lib/debug | cut -f1`"

I would use some different style of code here: `size_before=$(du -s … | cut -f1)`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/535#pullrequestreview-152640721
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20180905/9801b6ff/attachment.html>