[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

[Panu Matilainen]

pmatilai commented on this pull request.



> +    if (Ferror(fd)) {
+	rpmlog(RPMLOG_ERR, _("Unable to open temp file: %s\n"), Fstrerror(fd));
+	goto exit;
+    }
+
+    if ((fp = fdopen(Fileno(fd), "w")) == NULL) {
+	rpmlog(RPMLOG_ERR, _("Unable to open stream: %s\n"), strerror(errno));
+	goto exit;
+    }
+
+    fprintf(fp, "cd '%s'\n", buildDir);
+
+    if (spec->buildSubdir)
+    	fprintf(fp, "cd '%s'\n", spec->buildSubdir);
+    fprintf(fp, "%s", getStringBuf(spec->buildrequires));
+    (void) fclose(fp);

This script-running part with all the templating etc needs to be merged into doScript() really.
Make doScript() always use rpmfcExec() and return its output via pointer if supplied, and parse the output in the caller.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-223839526
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190408/b7198a54/attachment-0001.html>