[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

[Florian Festi]

ffesti commented on this pull request.



> +    if (Ferror(fd)) {
+	rpmlog(RPMLOG_ERR, _("Unable to open temp file: %s\n"), Fstrerror(fd));
+	goto exit;
+    }
+
+    if ((fp = fdopen(Fileno(fd), "w")) == NULL) {
+	rpmlog(RPMLOG_ERR, _("Unable to open stream: %s\n"), strerror(errno));
+	goto exit;
+    }
+
+    fprintf(fp, "cd '%s'\n", buildDir);
+
+    if (spec->buildSubdir)
+    	fprintf(fp, "cd '%s'\n", spec->buildSubdir);
+    fprintf(fp, "%s", getStringBuf(spec->buildrequires));
+    (void) fclose(fp);

Yeah, this ended up much closer to doScript() than anticipated. I started with trying to use doScript and that didn't work out. Now that most things from doScript got added merging the two functions looks much more natural.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#discussion_r273081320
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190408/2e1eab6a/attachment.html>