[Rpm-maint] [rpm-software-management/rpm] Warn if %else is after %else (#649)

[Panu Matilainen]

pmatilai requested changes on this pull request.

No problem with the change itself, but the commit message doesn't really convey what's going on.
On first sight the diff looks like excessive white-space changes or something, you need to look quite closely to see that the whole thing is renumbered to add room at the start.

With any changes, look at the diff on purely visual level and ask yourself is "what changes here?" immediately obvious in itself. If not, it should be spelled out in the commit message (but no need to get poetic about it)

With proper explanation, this and the move to an internal header can go together in a single commit.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/649#pullrequestreview-224301787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190409/2061313b/attachment.html>