[Rpm-maint] [rpm-software-management/rpm] Support build-id generation from compressed ELF files (#653)

Mark Wielaard mark at klomp.org
Tue Apr 9 22:04:00 UTC 2019


On Tue, 2019-04-02 at 06:32 -0700, Igor Gnatenko wrote:
> > @@ -487,6 +487,10 @@ AS_IF([test "$WITH_LIBELF" = yes],[
> 
>        # If possible we also want the strtab functions from elfutils
> 0.167.
>        # But we can fall back on the (unsupported) ebl alternatives
> if not.
>        AC_CHECK_LIB(dw, dwelf_strtab_init, [HAVE_LIBDW_STRTAB=yes])
> +      # whether libdw supports compressed ELF objects
> +      AC_CHECK_LIB(dw, dwelf_elf_begin, [
> +                   AC_DEFINE(HAVE_DWELF_ELF_BEGIN, 1, [Have
> dwelf_elf_begin?])
> 
> should we also change previous condition to use AC_DEFINE? just to be
> consistent. Because it uses AM_CONDITIONAL few lines below.

No. The AC_DEFINE is for use is C source code and defines a macro.
An AM_CONDITIONAL defines a conditional for use in an automake file.

The automake conditionals are used to decide how to link, the defines
are used to determine how/which functions to call in the code.

Cheers,

Mark


More information about the Rpm-maint mailing list