[Rpm-maint] [rpm-software-management/rpm] Alternative implementation of #663 (#665)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -807,7 +807,8 @@ package or when debugging this package.\
   RPM_OPT_FLAGS=\"%{optflags}\"\
   RPM_ARCH=\"%{_arch}\"\
   RPM_OS=\"%{_os}\"\
-  export RPM_SOURCE_DIR RPM_BUILD_DIR RPM_OPT_FLAGS RPM_ARCH RPM_OS\
+  RPM_BUILD_NCPUS=\"%{_smp_build_ncpus}\"\

Hmm, this should perhaps be %{?_smp_build_ncpus} since that macro comes from the platform-macros and in theory there could be platforms where it's not defined. OTOH might be saner to just move the whole ncpus business to the main macros file, dunno.

Other than that pondering, looks good to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/665#pullrequestreview-227129226
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190416/2b2337c2/attachment.html>