[Rpm-maint] [rpm-software-management/rpm] Fix rpm2archive behavior with multiple arguments (#681)

Panu Matilainen notifications at github.com
Tue Apr 30 09:14:41 UTC 2019


pmatilai commented on this pull request.



>  
-    ts = rpmtsFree(ts);
+    if (argc == 1)
+	argv[argc++] = "-";
+
+    for (i = 1; i < argc; i++) {
+	rpmts ts = rpmtsCreate();
+	rpmVSFlags vsflags = 0;
+
+	/* XXX retain the ageless behavior of rpm2cpio */
+	vsflags |= RPMVSF_MASK_NODIGESTS;
+	vsflags |= RPMVSF_MASK_NOSIGNATURES;
+	vsflags |= RPMVSF_NOHDRCHK;
+	(void) rpmtsSetVSFlags(ts, vsflags);
+

All this transaction fiddling should be done exactly once, outside the loop.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/681#pullrequestreview-232066019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190430/22143d26/attachment.html>


More information about the Rpm-maint mailing list