[Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

Panu Matilainen notifications at github.com
Tue Aug 6 05:46:27 UTC 2019


pmatilai requested changes on this pull request.

If I interpret that correctly, you just dismiss all the spaces that might be there. So what if you WANT to emit spaces? Also, the triple syntax has to give the same exact results as doing the same thing without the older conditional operator for consistency's and sanity's sake.

If I interpret that correctly, you just dismiss all the spaces that might be there. So what if you WANT to emit spaces? It's equally common and legit thing to do. Also, the triple syntax has to give the same exact results as doing the same thing without the older conditional operator for consistency's and sanity's sake.

Rip out support for all those extra spaces, I'm not going to accept this as long as they're there.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/746#pullrequestreview-271125720
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190805/1831b683/attachment.html>


More information about the Rpm-maint mailing list