[Rpm-maint] [rpm-software-management/rpm] Hidden doc copy failures in rpm-4.11.x (#808)

tcely notifications at github.com
Wed Aug 7 22:19:46 UTC 2019


https://github.com/rpm-software-management/rpm/blob/7b5db7d98e024ebc582242712e56e603616144c0/build/files.c#L1733-L1758

https://github.com/rpm-software-management/rpm/blob/7b5db7d98e024ebc582242712e56e603616144c0/build/files.c#L1742-L1750

By collecting the files and generating a series of `cp` commands, this means the return code check is controlled by the last `cp` line in that script.

Using something like `set -e` would allow checking for any copy failures, but may mean some copies are not attempted. A better approach is setting a failure flag for all failures and only returning success from the script if that flag was never set.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/808
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190807/e1aafb72/attachment.html>


More information about the Rpm-maint mailing list