[Rpm-maint] [rpm-software-management/rpm] Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests (#810)

pavlinamv notifications at github.com
Fri Aug 9 15:02:25 UTC 2019


It corrects warnings  [SC2166] spotted by covscan:
warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. [SC2166]
warning: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. [SC2166]

Motivated by last the comment in #802. This should fix all [sc2166] warnings spotted by covscan on RPM version 4.14.2.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/810

-- Commit Summary --

  * Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests

-- File Changes --

    M scripts/brp-compress (2)
    M scripts/brp-java-gcjcompile (4)
    M scripts/brp-python-bytecompile (12)
    M scripts/brp-python-hardlink (2)
    M scripts/brp-strip (2)
    M scripts/brp-strip-comment-note (2)
    M scripts/brp-strip-shared (2)
    M scripts/brp-strip-static-archive (2)
    M scripts/check-buildroot (2)
    M scripts/check-rpaths (2)
    M scripts/find-debuginfo.sh (6)
    M scripts/find-lang.sh (6)
    M scripts/gendiff (2)
    M scripts/rpm2cpio.sh (2)
    M scripts/tgpg (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/810.patch
https://github.com/rpm-software-management/rpm/pull/810.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/810
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190809/4c6abb88/attachment.html>


More information about the Rpm-maint mailing list