[Rpm-maint] [rpm-software-management/rpm] Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests (#810)

Panu Matilainen notifications at github.com
Tue Aug 13 11:50:04 UTC 2019


The change might be fine as such, but the summary is unreadable and overall the message largely fails to explain *why* should one syntax be preferred over another one. "Because covscan" is not a proper reason.

test(1) man page gives a clue:
```
NOTE:  Binary  -a and -o are inherently ambiguous.  Use 'test EXPR1 &&
test EXPR2' or 'test EXPR1 || test EXPR2' instead.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/810#issuecomment-520802846
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190813/49172268/attachment.html>


More information about the Rpm-maint mailing list