[Rpm-maint] [rpm-software-management/rpm] Restore strict order of build scriptlet stdout/stderr output (#794) (#818)

Panu Matilainen notifications at github.com
Thu Aug 15 11:56:41 UTC 2019


Commit 18e8f4e9b2dd170d090843adf5b5084658d68cf7 and related changes caused us to capture and re-emit stdout of all build scriptlets, whether we actually use the output for anything or not. Besides doing a whole bunch of work for nothing, this can disrupt the output of build scriptlets by making the output jerky and out of order, at least inside mock and other tools which in turn grab rpm output. This makes troubleshooting failed builds unnecessarily hard for no good reason.
    
Handle the whole thing in a different way: on regular builds, don't capture anything where we don't actually need to. This restores the natural flow of output. We still need to somehow handle quiet builds though, and we can't use redirect to /dev/null from %___build_pre like we used to, because dynamic buildrequires need to provide output even on quiet builds. So somewhat counter-intuitively, we need to capture the output in order to discard it.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/818

-- Commit Summary --

  * Support running rpmfcExec() without any piped input/output
  * Restore strict order of build scriptlet stdout/stderr output (#794)
  * Drop the no longer needed rpmfcExec() output duplication support

-- File Changes --

    M build/build.c (17)
    M build/files.c (2)
    M build/rpmbuild_internal.h (3)
    M build/rpmfc.c (19)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/818.patch
https://github.com/rpm-software-management/rpm/pull/818.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/818
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190815/1baf30b3/attachment-0001.html>


More information about the Rpm-maint mailing list