[Rpm-maint] [rpm-software-management/rpm] Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests (#810)

Panu Matilainen notifications at github.com
Mon Aug 19 12:44:16 UTC 2019


When pushing updates to address comments, make a note of what you changed here. It's not always that obvious, and pushes without comments go easily unnoticed overall.

""Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]'" describes the literal change done by the patch. This is not useful information because that's what the patch itself is for! The commit summary + message is about rationale of the change. "in tests" is also problematic because it too is unnecessarily ambiguous - does it refer to the tests in testsuite or something else?

Something along the lines of "Eliminate use of ambiguous logical operators in script conditionals" would be at least closer to the mark.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/810#issuecomment-522555934
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190819/52157ba1/attachment.html>


More information about the Rpm-maint mailing list