[Rpm-maint] [rpm-software-management/rpm] Add %{expr:...} macro for parsing expressions (#817)

pavlinamv notifications at github.com
Wed Aug 21 06:55:13 UTC 2019


> The error messages are simply the same as you get from spec %if conditionals, there are no messages added / changed in this PR. That's not to say the messages couldn't maybe be improved, but any change needs to account for the fact that they're shared between two quite different contexts.

Not  entirely. If there is a problem in spec %if conditional, then two error messages are emitted e.g.:

```
error: syntax error while parsing ==
error: /data/SPECS/iftest.spec:22: bad %if condition:  =
```

But if the same wrong conditional is used after _%{expr_ (e.g. %{expr:=}) only the first error message is emitted:

```
error: syntax error while parsing ==
```

> There was an actual bug wrt errors in that expression errors did not raise a macro-level error. Fixed now.

Yes this is corrected now.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/817#issuecomment-523323551
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190820/74a3b3ed/attachment.html>


More information about the Rpm-maint mailing list