[Rpm-maint] [rpm-software-management/rpm] Cap number of threads on 32bit platforms, add a tunable (RhBug:1729382) (#823)

Panu Matilainen notifications at github.com
Fri Aug 23 08:31:36 UTC 2019


On 32bit plaforms, address space is easily exhausted with multiple threads, causing arbitrary builds failure regressions (RhBug:1729382). Simply cap the number of threads to maximum of four on any 32bit platform to play it safe. It's still three more than we were able to use on older releases...
    
In addition, introduce a separate tunable for tweaking the maximum number of threads just in case, defaulting to max CPUs available.

This is a stopgap solution to the 32bit arch build regressions in 4.15.x (RhBug:1729382) that is simple and straightforward enough for 4.15.0. The more elaborate heuristics suggested in PR #821 need more time for discussing, tweaking and testing than we have right now.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/823

-- Commit Summary --

  * Fix build code thread cap logic for unlimited CPUs
  * Cap number of threads on 32bit platforms, add a tunable (RhBug:1729382)

-- File Changes --

    M build/parseSpec.c (15)
    M platform.in (3)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/823.patch
https://github.com/rpm-software-management/rpm/pull/823.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/823
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190823/0caf7a24/attachment-0001.html>


More information about the Rpm-maint mailing list