[Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)

Mark Wielaard mark at klomp.org
Mon Aug 26 10:37:23 UTC 2019


On Mon, Aug 26, 2019 at 02:44:22AM -0700, Tom de Vries wrote:
> There's code setting variable id in scripts/find-debuginfo.sh, but there's no
> subsequent use.  The only use of $id in the script is in do_file, where it is
> a local variable.
> The variable setting was introduced in commit 6b3b435fa "Add dwz debuginfo
> compression support" in combination with a subsequent make_id_link using the
> variable, but the make_id_link was removed in commit bbfe1f86b
> "Add build-id links to rpm for all ELF files".
> Remove the unused variable.

Thanks for looking through the history.
This makes sense, the id variable should have been removed when
the only usage of it for make_id_link was removed. Now it just does
extra work for nothing.



More information about the Rpm-maint mailing list