[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

pavlinamv notifications at github.com
Fri Feb 1 20:51:53 UTC 2019


Before this commit, rpm handles text after %else or %endif
nonconsistently and does not give any feedback:
- a text after %else was expanded according to evaluation
  of the previous %if.
- a text after %endif was expanded according to evaluation
  of the previous %else, resp. %if if there was no %else.

So in the current spec files there exist lines like:
    %else %if 0%{?centos}
    %else !use_embedded
    %endif # with_perf
(comments must have '#' at the start of the line to behave as defined)

So to be consistent and clear, this warning is added. It looks
for example:

warning: line 93, no text in allowed after %else
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/625

-- Commit Summary --

  * Warn if a text is after %else or %endif

-- File Changes --

    M build/parseSpec.c (24)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/625.patch
https://github.com/rpm-software-management/rpm/pull/625.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190201/0637fa80/attachment.html>


More information about the Rpm-maint mailing list