[Rpm-maint] [rpm-software-management/rpm] Warn if a text is after %else or %endif (#625)

Panu Matilainen notifications at github.com
Wed Feb 27 11:16:13 UTC 2019


Much better, thanks. Two (hopefully) final minor nits:
- The line type parsing change is non-trivial enough that it deserves the *actual* rationale in the commit message, otherwise it looks just like a whole lot of trouble for nothing: we'll need to parse the same thing in two different places in the following commits.
- goto-labels are never indented to make them stand out from the rest of the code. So yes, the pre-existing retry: label in that function is mis-indented. Feel free to add another commit fixing that too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/625#issuecomment-467823646
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190227/0249a14a/attachment.html>


More information about the Rpm-maint mailing list