[Rpm-maint] [rpm-software-management/rpm] implement %elif (#613)

Panu Matilainen notifications at github.com
Wed Jan 16 12:46:24 UTC 2019


pmatilai commented on this pull request.



>  	spec->readStack = rl;
 	spec->line[0] = '\0';
+    } else if (isElif) {
+	spec->readStack->reading = match && spec->readStack->readable;
+	if (spec->readStack->reading)
+	    spec->readStack->readable = 0;
+	spec->line[0] = '\0';
+	match = -1;

Well, I wouldn't be asking for you to rethink over and over again if *I* was happy with the code.
Which is why I've been asking for you to rethink at a more fundamental level, fundamental meaning something deeper than moving around a few lines of existing code.

So we have a bit of a stalemate here: if you can't see anything wrong with this code then clearly I'm not going to get anything better by asking for a rethink.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/613#discussion_r248266809
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190116/89441aa9/attachment.html>


More information about the Rpm-maint mailing list