[Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

pavlinamv notifications at github.com
Mon Jul 29 10:27:29 UTC 2019

>There  is no reason to break support for this,

@Conan-Kudo, @ignatenkobrain: 
The current situation is: 
rpm accepts arbitrary text as a time zone description in extended date format. If the time zone description is not "correct" rpm (silently) change it to UTC instead of the given time zone description (reason of RhBug 1715412). 

In more detail:
rpm uses the C standard library time.h (function mktime()) for solving tasks regarding time zones. Before using mktime() it is necessary to set the particular name of timezone into 'TZ' environment variable. TZ variable can be set using several formats [1]. None of them is the time zone abbreviation like EDT or CET or CEST. If the TZ contains text in:
- the proper format mktime() converts the input structure according to TZ,
- otherwise it converts the input structure according to UTC without any warning/info.

I discussed the situation with Florian Weimer (he is familiar with time.h). He wrote that the time zone abbreviations are not valid time zone identifiers as far as tzdata or glibc's tzset function are concerned. He recommends to change the format to encode UTC offsets explicitly. 

That is why I proposed the current PR. I am not happy with this the proposed solution, but I do not see a better one.

[1] https://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190729/9df8f940/attachment-0001.html>

More information about the Rpm-maint mailing list