[Rpm-maint] [rpm-software-management/rpm] Stop immediately if there is a problem with Source (#730)

Igor Gnatenko notifications at github.com
Sun Jun 2 17:46:50 UTC 2019


First issue is that doUntar() when encounters an issue related to the
spec file, returns non-NULL which indicates that no error has happened.
Second is that even if it would return that, parsePrep() is simply
ignores return code.

Also be more consistent with "goto exit;".

Fixes: 76c429c3178c965c6517629957a633768132904c
Fixes: c7a8c1e079d2a166b9848ae6afa1b0cfab1b250a
Fixes: https://github.com/rpm-software-management/rpm/issues/728
Signed-off-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/730

-- Commit Summary --

  * Stop immediately if there is a problem with Source

-- File Changes --

    M build/parsePrep.c (13)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/730.patch
https://github.com/rpm-software-management/rpm/pull/730.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/730
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190602/90916f00/attachment.html>


More information about the Rpm-maint mailing list