[Rpm-maint] [rpm-software-management/rpm] rpmfc: Return failures in rpmfcExec (#729)

Panu Matilainen notifications at github.com
Mon Jun 3 11:21:23 UTC 2019


pmatilai commented on this pull request.



> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     }
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
 		       failnonzero, buildRoot, dup);
-    if (ec) {
-	sb = freeStringBuf(sb);
-    }

This has consequences for callers who expect the former behavior. At least it introduces a memory leak to rpmfcApplyExternal() AFAICS.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/729#pullrequestreview-244818803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190603/4527be43/attachment.html>


More information about the Rpm-maint mailing list