[Rpm-maint] [rpm-software-management/rpm] rpmfc: Return failures in rpmfcExec (#729)

Igor Gnatenko notifications at github.com
Mon Jun 3 11:34:06 UTC 2019

ignatenkobrain commented on this pull request.

> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
 		       failnonzero, buildRoot, dup);
-    if (ec) {
-	sb = freeStringBuf(sb);
-    }

I can restore this with just adding `goto exit;` if that is what you would prefer.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190603/62771486/attachment.html>

More information about the Rpm-maint mailing list