[Rpm-maint] [rpm-software-management/rpm] rpmfc: Return failures in rpmfcExec (#729)

Panu Matilainen notifications at github.com
Mon Jun 3 12:07:57 UTC 2019


pmatilai commented on this pull request.



> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     }
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
 		       failnonzero, buildRoot, dup);
-    if (ec) {
-	sb = freeStringBuf(sb);
-    }

I didn't say I want it restored, I just said it has consequences that need to be dealt with.

The question is whether we actually want to change the behavior. I looked at this very thing when reviewing the dynamic buildrequires patches and while wanting the output might seem obvious, we actually have it already because it's duplicated to actual stdout descriptor in the cases where we care about the output. Or that's how it looks to me, but do you have a concrete case where something important is not shown because of this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/729#discussion_r289811878
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190603/aa1fc926/attachment.html>


More information about the Rpm-maint mailing list