[Rpm-maint] [rpm-software-management/rpm] rpmfc: Return failures in rpmfcExec (#729)

Panu Matilainen notifications at github.com
Mon Jun 3 12:17:26 UTC 2019

pmatilai commented on this pull request.

> @@ -444,17 +444,12 @@ int rpmfcExec(ARGV_const_t av, StringBuf sb_stdin, StringBuf * sb_stdoutp,
     ec = getOutputFrom(xav, buf_stdin, buf_stdin_len, sb,
 		       failnonzero, buildRoot, dup);
-    if (ec) {
-	sb = freeStringBuf(sb);
-    }

What I think is that this whole move to rpmfcExec() has started increasingly  feeling like a mistake. :grimacing: But it's a bit late to revert, that'd be a huge mess too.

I agree lets just leave it the way it is for now.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190603/1937df5a/attachment.html>

More information about the Rpm-maint mailing list