[Rpm-maint] [rpm-software-management/rpm] Fix bogus if-condition in find-debuginfo.sh (#735) (#737)

Panu Matilainen notifications at github.com
Wed Jun 5 06:42:45 UTC 2019

pmatilai commented on this pull request.

It might be implemented internally in bash, but generally speaking "[" is an external command (try 'ls -l /bin/[') and needs to be surrounded by space, and even in bash it's common good style anyway (see elsewhere in the script). Shell coding style differs from that of C...

For the same externality reason (ie to avoid fork+exec), the [ command implements it's own and-operator as -a switch, which is commonly used in find-debuginfo.sh instead of &&, but that's strictly optional as find-debuginfo is a bash script.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190604/b710db24/attachment-0001.html>

More information about the Rpm-maint mailing list