[Rpm-maint] [rpm-software-management/rpm] Fix rpmVerifySignatures() passing garbage as verify flags in rpm >= 4.14 (#747)

Panu Matilainen notifications at github.com
Wed Jun 12 10:16:28 UTC 2019

Commit a239ddefa90575ce80ed4436beb4005a97e32644 changed rpmpkgVerifySigs()
to accept fine-grained vsflags instead of query/verify style
nosignature/nodigest hammers, but rpmVerifySignatures() didn't get
updated accordingly. This will cause most unexpect behavior (in particular
in 4.14.x), for example QUERY_DIGEST which was used for disabling all
digest verification was defined as (1 << 19), which happens to be the same
as RPMVSF_NORSA which is how it would now be treated. Similarly confusion

Just use the transaction verify flags instead, and mark the qva argument
as unused. It's an API change but that's okay in 4.15, and it's also an
explicit breakage at compile time (due to those DIGEST/SIGNATURE symbols
removal). In 4.14.x this is a regression but can be fixed within the API.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Fix rpmVerifySignatures() passing garbage as verify flags in rpm >= 4.14

-- File Changes --

    M lib/rpmchecksig.c (3)
    M lib/rpmcli.h (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190612/c56f4750/attachment.html>

More information about the Rpm-maint mailing list