[Rpm-maint] [rpm-software-management/rpm] Drop bogus condition from header index allocation (#748)

Panu Matilainen notifications at github.com
Thu Jun 13 09:35:53 UTC 2019

We always allocate the index here as should be obvious from the code,
the condition is a leftover that might've been relevant in the turn
of the millenium but not anymore.

This construct confused clang into thinking there's a NULL pointer
dereference at the end of a long callchain (maybe because the indexlen
argument is signed so if you passed in -1 as indexLen... but fixing
those int32_t's is another story)
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Drop bogus condition from header index allocation

-- File Changes --

    M lib/header.c (5)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190613/e734954e/attachment-0001.html>

More information about the Rpm-maint mailing list